Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALTER MODIFY ORDER BY #3581

Merged
merged 30 commits into from
Dec 3, 2018
Merged

ALTER MODIFY ORDER BY #3581

merged 30 commits into from
Dec 3, 2018

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Nov 14, 2018

No description provided.

Alexey Zatelepin added 20 commits November 13, 2018 16:12
add primary key syntax [#CLICKHOUSE-3859]
580146e
sort key is distinct from primary key [#CLICKHOUSE-3859]
9a92c0a
separate sorting key and primary key, allow setting primary key separ…
0fa8616 
…ately [#CLICKHOUSE-3859]
renames [#CLICKHOUSE-3859]
f4c26e7
comments [#CLICKHOUSE-3859]
c4bf38e
ALTER MODIFY ORDER BY syntax [#CLICKHOUSE-3859]
0233724
ALTER ORDER BY for ordinary MergeTree [#CLICKHOUSE-3859]
07a2210
add sorting_and_primary_keys_independent [#CLICKHOUSE-3859]
0c0c4fd
Stat data in ZooKeeperNodeCache [#CLICKHOUSE-3859]
a0a9aad
allow arbitrary callbacks in ZooKeeperNodeChange [#CLICKHOUSE-3859]
ce1ead5
write metadata znode in StorageReplicatedMergeTree::alter() [#CLICKHO…
4036ec8 
…USE-3859]
apply changes in ReplicatedMergeTreeAlterThread [#CLICKHOUSE-3859]
106800b
fix use-after-free in ZooKeeperNodeCache [#CLICKHOUSE-3859]
96d7eee
apply metadata changes on startup [#CLICKHOUSE-3859]
74c48ed
calculate ReplicatedMergeTreeTableMetadata diff [#CLICKHOUSE-3859]
31a6a6b
store original key ASTs, and not extracted ASTExpressionLists [#CLICK…
8b85822 
…HOUSE-3859]
fix prewhere with FINAL for VersionedCollapsingMergeTree [#CLICKHOUSE…
7167bfd 
…-3859]
rearrange AST members in MergeTreeData [#CLICKHOUSE-3859]
2cc0aae
Merge branch 'master' into alter-order-by
29b3436 
Conflicts:
	dbms/src/Interpreters/ExpressionAnalyzer.cpp
	dbms/src/Storages/MergeTree/MergeTreeData.cpp
	dbms/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp
add checks for ALTER MODIFY ORDER BY [#CLICKHOUSE-3859]
b071547
@ztlpn ztlpn requested a review from abyss7 November 14, 2018 17:19
@abyss7
Copy link
Contributor

abyss7 commented Nov 15, 2018

I'm in progress of looking into it

abyss7
abyss7 reviewed Nov 22, 2018
View reviewed changes
Copy link
Contributor

@abyss7 abyss7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some tests on MODIFY PRIMARY KEY with regard to new restrictions between primary and sorting keys?

dbms/src/Storages/AlterCommands.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/AlterCommands.cpp Show resolved Hide resolved
dbms/src/Storages/AlterCommands.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/AlterCommands.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/MergeTree/MergeTreeDataWriter.cpp Show resolved Hide resolved
dbms/src/Interpreters/MutationsInterpreter.cpp Show resolved Hide resolved
dbms/src/Storages/MergeTree/MergeTreeData.h Show resolved Hide resolved
Alexey Zatelepin added 3 commits November 26, 2018 16:01
Merge branch 'master' into alter-order-by
d3d9242 
Conflicts:
	dbms/src/Parsers/ASTAlterQuery.h
	dbms/src/Parsers/ParserAlterQuery.cpp
	dbms/src/Storages/AlterCommands.cpp
	dbms/src/Storages/AlterCommands.h
adapt code of #3609 [#CLICKHOUSE-3859]
e085bc9
better names in ZooKeeperNodeCache [#CLICKHOUSE-3859]
ceea7bd
@alexey-milovidov alexey-milovidov merged commit cec4935 into master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abyss7 abyss7 abyss7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ztlpn @abyss7 @alexey-milovidov