CLICKHOUSE-4109 mlock clickhouse #3553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Missing linuxCapability.h. |
| /* | ||
| #if NDEBUG | ||
| memory_amount > 16000000000 | ||
| ? true // Change me to true in future |
| #if defined(__linux__) | ||
| if (config().getBool("mlock_executable", | ||
| false // TODO: uncomment after tests: | ||
| /* |
| } | ||
| else | ||
| { | ||
| LOG_INFO(log, "It looks like the process has no CAP_IPC_LOCK capability, binary mlock will be disabled." |
| " It could happen due to incorrect ClickHouse package installation." | ||
| " You could resolve the problem manually with 'sudo setcap cap_ipc_lock=+ep /usr/bin/clickhouse'." | ||
| " Note that it will not work on 'nosuid' mounted filesystems."); | ||
|
|
| const auto memory_amount = getMemoryAmount(); | ||
| { /// After full config loaded | ||
| #if defined(__linux__) | ||
| if (config().getBool("mlock_executable", |
There was a problem hiding this comment.
Missing an entry in config.xml along with its documentation.
alexey-milovidov
added a commit
that referenced
this pull request
Nov 14, 2018
|
|
||
| bool hasLinuxCapability(decltype(CAP_NET_ADMIN) cap) | ||
| { | ||
| static bool res = hasLinuxCapabilityImpl(cap); |
There was a problem hiding this comment.
This is totally wrong.
|
|
||
| namespace | ||
| { | ||
| bool hasLinuxCapabilityImpl(decltype(CAP_NET_ADMIN) cap) |
|
|
||
| if (!((1 << cap) & response.effective)) | ||
| return false; | ||
|
|
alexey-milovidov
added a commit
that referenced
this pull request
Nov 14, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Nov 21, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Nov 22, 2018
Fixed error introduced in #3553 and prevent it happening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en