Implement 'ALTER … FREEZE' command #3514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztlpn
reviewed
Nov 7, 2018
Need some tests!
abyss7
force-pushed
the
CLICKHOUSE-3766
branch
from
7e7f168 to
4eb0f33
Compare
abyss7
force-pushed
the
CLICKHOUSE-3766
branch
from
3337bbe to
1e070a7
Compare
ztlpn
reviewed
Nov 21, 2018
| */ | ||
| virtual void freezePartition(const ASTPtr & /*partition*/, const String & /*with_name*/, const Context & /*context*/) | ||
| virtual void partition(const ASTPtr & /* query */, const PartitionCommands & /* commands */, const Context & /* context */) |
There was a problem hiding this comment.
Good idea, but I'd call this method alterPartition instead (it doesn't partition anything, it alters partitions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en