Support more hash functions for tuple, unify FunctionHash template. [CLICKHOUSE-3490] #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| static UInt64 mergeHashes(UInt64 h1, UInt64 h2) | ||
| { | ||
| return IntHash64Impl::apply(h1) ^ h2; |
There was a problem hiding this comment.
If the main hash function is cryptographic, we must use cryptographic hash function to combine too.
There was a problem hiding this comment.
How to do it, variants:
combine(x, y) = sipHash64(x || y)where||is "concatenation".- if there was more than one element in tuple, update (
SipHash::update,MD5_update, etc.) state by length of each element then by contents of each element; and finalize at the end.
|
|
||
| SELECT murmurHash3_64(1, 2, 3); | ||
| SELECT murmurHash3_64(1, 3, 2); | ||
| SELECT murmurHash3_64('a', [1, 2, 3], 4); |
There was a problem hiding this comment.
And please add also a test with tuple argument or multiple arguments, one of them is tuple.
| 3533626746 | ||
| 2388617433 | ||
| 2708309598 | ||
| 3012058918 |
There was a problem hiding this comment.
Don't understand, why it was changed...
There was a problem hiding this comment.
It's just changed to intHash32 or intHash64 as it was for other non-crypto hash functions.
I don't think it is expected behaviour.
|
Even halfMD5 is switched to intHash for integers. This is totally wrong. Will fix. |
alexey-milovidov
added a commit
that referenced
this pull request
Nov 1, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Nov 1, 2018
Fixed idiosyncrasy with hash functions introduced in #3451
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en