Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Nullable types in MySQL, ODBC and MongoDB external sources #3362

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

alexey-milovidov
Copy link
Member

@alexey-milovidov
Copy link
Member Author

Example:

CREATE TABLE mysql_information_schema_tables (
  `TABLE_CATALOG` Nullable(String),
  `TABLE_SCHEMA` Nullable(String),
  `TABLE_NAME` Nullable(String),
  `TABLE_TYPE` Nullable(String),
  `ENGINE` Nullable(String),
  `VERSION` Nullable(UInt64),
  `ROW_FORMAT` Nullable(String),
  `TABLE_ROWS` Nullable(UInt64),
  `AVG_ROW_LENGTH` Nullable(UInt64),
  `DATA_LENGTH` Nullable(UInt64),
  `MAX_DATA_LENGTH` Nullable(UInt64),
  `INDEX_LENGTH` Nullable(UInt64),
  `DATA_FREE` Nullable(UInt64),
  `AUTO_INCREMENT` Nullable(UInt64),
  `CREATE_TIME` Nullable(DateTime),
  `UPDATE_TIME` Nullable(DateTime),
  `CHECK_TIME` Nullable(DateTime),
  `TABLE_COLLATION` Nullable(String),
  `CHECKSUM` Nullable(UInt64),
  `CREATE_OPTIONS` Nullable(String),
  `TABLE_COMMENT` Nullable(String)
) ENGINE = MySQL('127.0.0.1:3306', INFORMATION_SCHEMA, TABLES, 'root', 'my-secret-pw')

SELECT * FROM mysql_information_schema_tables;

@alesapin
Copy link
Member

LGTM

@alexey-milovidov alexey-milovidov merged commit b1ceb4b into master Oct 12, 2018
@alexey-milovidov
Copy link
Member Author

TODO: Integration test.

@Felixoid Felixoid deleted the nullable-types-from-external-databases branch April 10, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants