Support {database} and {table} macros in ReplicatedMergeTree [CLICKHOUSE-3897] #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +30,7 @@ class Macros | |||
| /** Replace the substring of the form {macro_name} with the value for macro_name, obtained from the config file. | |||
There was a problem hiding this comment.
Missing update of comment.
dbms/src/Common/Macros.cpp
Outdated
| auto it = macros.find(macro_name); | ||
| if (it == macros.end()) | ||
| throw Exception("No macro " + macro_name + " in config", ErrorCodes::SYNTAX_ERROR); | ||
| if (macro_name == "database") |
There was a problem hiding this comment.
Explicitly defined "database" and "table" macros should be preferred over implicit values.
| @@ -207,7 +207,7 @@ StorageReplicatedMergeTree::StorageReplicatedMergeTree( | |||
| : context(context_), | |||
| database_name(database_name_), | |||
| table_name(name_), full_path(path_ + escapeForFileName(table_name) + '/'), | |||
| zookeeper_path(context.getMacros()->expand(zookeeper_path_)), | |||
| zookeeper_path(context.getMacros()->expand(zookeeper_path_, 0, database_name, table_name)), | |||
| replica_name(context.getMacros()->expand(replica_name_)), | |||
There was a problem hiding this comment.
Why don't allow database and table macros here?
| @@ -207,7 +207,7 @@ StorageReplicatedMergeTree::StorageReplicatedMergeTree( | |||
| : context(context_), | |||
| database_name(database_name_), | |||
| table_name(name_), full_path(path_ + escapeForFileName(table_name) + '/'), | |||
| zookeeper_path(context.getMacros()->expand(zookeeper_path_)), | |||
| zookeeper_path(context.getMacros()->expand(zookeeper_path_, 0, database_name, table_name)), | |||
There was a problem hiding this comment.
You should overload expand method for convenience.
| ddl_check_query(instance, "DROP TABLE IF EXISTS test_db.test_macro ON CLUSTER '{cluster}'") | ||
| ddl_check_query(instance, "CREATE DATABASE IF NOT EXISTS test_db ON CLUSTER '{cluster}'") | ||
|
|
||
| ddl_check_query(instance, """ |
There was a problem hiding this comment.
Why don't have a separate test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en