Formats/CapnProtoRowInputStream: support Nested and Tuple, fix alignm… #3216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent issues
This updated contrib/capnproto to a newer version that fixes problems with
unaligned access to message frames.
It also adds support for parsing Struct types as Tuple (named or unnamed),
and Nested array types.
The `struct X { a @0 :UInt64; b @1 :Text }` in Cap'nProto is equivalent to
`x Tuple(a UInt64, b String)` in ClickHouse.
Arrays of Struct types such as `y List(X)` are equivalent to `y Nested(a UInt64, b String)`.
vavrusa
force-pushed
the
capnproto-tuple-nested
branch
from
bfc5935
to
cbbcb6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent issues
This updated contrib/capnproto to a newer version that fixes problems with
unaligned access to message frames.
It also adds support for parsing Struct types as Tuple (named or unnamed),
and Nested array types.
The
struct X { a @0 :UInt64; b @1 :Text }in Cap'nProto is equivalent tox Tuple(a UInt64, b String)in ClickHouse.Arrays of Struct types such as
y List(X)are equivalent toy Nested(a UInt64, b String).I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
cc @bocharov @dqminh