Added cache for low cardinality function result. #3200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KochetovNicolai
force-pushed
the
low-cardinality-function-result-cache
branch
from
c34d703
to
d526859
Compare
KochetovNicolai
changed the title
| @@ -109,8 +109,8 @@ namespace | |||
| } | |||
|
|
|||
|
|
|||
| ColumnWithDictionary::ColumnWithDictionary(MutableColumnPtr && column_unique_, MutableColumnPtr && indexes_) | |||
| : dictionary(std::move(column_unique_)), idx(std::move(indexes_)) | |||
| ColumnWithDictionary::ColumnWithDictionary(MutableColumnPtr && column_unique_, MutableColumnPtr && indexes_, bool is_shared) | |||
There was a problem hiding this comment.
Missing comment about is_shared.
We should try to utilize COWPtr for this purpose (to unshare ColumnUnique on mutating operations).
| @@ -41,6 +42,64 @@ namespace ErrorCodes | |||
| } | |||
|
|
|||
|
|
|||
| class PreparedFunctionLowCardinalityResultCache | |||
| @@ -87,7 +90,8 @@ struct ExpressionAction | |||
|
|
|||
| /// For APPLY_FUNCTION and LEFT ARRAY JOIN. | |||
| FunctionBuilderPtr function_builder; | |||
| FunctionBasePtr function; | |||
| FunctionBasePtr function_base; | |||
There was a problem hiding this comment.
Need to either:
- remove some of these members;
- write a comment about each.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en