CLICKHOUSE-3947 add LIKE and IN () for ODBC and MySQL #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 20, 2018 17:34
This was referenced Sep 20, 2018
VadimPlh
changed the title
|
I remember about tests. |
alesapin
reviewed
Oct 9, 2018
| @@ -81,9 +123,10 @@ String transformQueryForExternalDatabase( | |||
| * copy only compatible parts of it. | |||
| */ | |||
|
|
|||
| const ASTPtr & original_where = typeid_cast<const ASTSelectQuery &>(query).where_expression; | |||
| const ASTPtr & original_where = typeid_cast<const ASTSelectQuery &>(*clone_query).where_expression; | |||
There was a problem hiding this comment.
Why we need const here If we change that variable inside replaceConstFunction?
|
|
||
| if (const ASTFunction * function = typeid_cast<const ASTFunction *>(&*child)) | ||
| { | ||
| auto result_block = getBlockWithConstants(function->clone(), context, all_columns); |
There was a problem hiding this comment.
getBlockWithConstants doesn't change its first argument. What purpose of clone?
|
lgtm, wait for tests |
|
Does not work at all. Tests were bogus and code review was pointless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en