[CLICKHOUSE-3476] add invalidate_query for ClickHouse in Dictionary #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesapin
requested changes
Sep 13, 2018
| return readInvalidateQuery(dynamic_cast<IProfilingBlockInputStream&>((*input_block))); | ||
| } | ||
|
|
||
| auto invalidate_stream = RemoteBlockInputStream(pool, request, invalidate_sample_block, context); |
There was a problem hiding this comment.
Why not RemoteBlockInputStream invalidate_stream(pool, request, invalidate_sample_block, context);?
| @@ -143,4 +159,19 @@ BlockInputStreamPtr ClickHouseDictionarySource::createStreamForSelectiveLoad(con | |||
| return std::make_shared<RemoteBlockInputStream>(pool, query, sample_block, context); | |||
| } | |||
|
|
|||
| std::string ClickHouseDictionarySource::doInvalidateQuery(const std::string & request) const | |||
| { | |||
| Block invalidate_sample_block; | |||
There was a problem hiding this comment.
Unused variable in case of is_local. Better to create if (is_local) ... else ....
| @@ -143,4 +159,19 @@ BlockInputStreamPtr ClickHouseDictionarySource::createStreamForSelectiveLoad(con | |||
| return std::make_shared<RemoteBlockInputStream>(pool, query, sample_block, context); | |||
| } | |||
|
|
|||
| std::string ClickHouseDictionarySource::doInvalidateQuery(const std::string & request) const | |||
| { | |||
| Block invalidate_sample_block; | |||
There was a problem hiding this comment.
This block is sample_block, which is used as header. It must contain single string column. Look at similar dictionaries: https://github.com/yandex/ClickHouse/blob/master/dbms/src/Dictionaries/MySQLDictionarySource.cpp#L219-L221 and https://github.com/yandex/ClickHouse/blob/master/dbms/src/Dictionaries/ODBCDictionarySource.cpp#L187-L189
There was a problem hiding this comment.
No! It does not work with CH.
|
Ok. But test is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en