ISSUES-2560 fix crash when create temporary with in clause #3098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang2014
force-pushed
the
fix/ISSUES-2560
branch
from
b75fe85
to
ed90f4d
Compare
zhang2014
commented
Sep 11, 2018
| @@ -135,9 +135,6 @@ InterpreterSelectQuery::InterpreterSelectQuery( | |||
| , input(input_) | |||
| , log(&Logger::get("InterpreterSelectQuery")) | |||
| { | |||
| if (!context.hasQueryContext()) | |||
There was a problem hiding this comment.
Here is the cause of the problem, all queries without query_context and containing in clauses will crash. Because it's exposing the internal context.
zhang2014
force-pushed
the
fix/ISSUES-2560
branch
from
ed90f4d
to
5834b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2560
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en