Aggregate function states addition [CLICKHOUSE-3723] #3062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for (size_t i = 0; i < 2; ++i) | ||
| columns[i] = typeid_cast<const ColumnAggregateFunction *>(block.getByPosition(arguments[i]).column.get()); | ||
|
|
||
| auto arena = std::make_shared<Arena>(); |
| auto & vec_to = column_to->getData(); | ||
| auto & vec_from = column_from->getData(); | ||
|
|
||
| UInt64 m = block.getByPosition(new_arguments[1]).column->getUInt(0); |
There was a problem hiding this comment.
How do you check that the argument is constant?
(Need to add a test when it is not.)
What if block has size number of rows?
|
|
||
| if (!new_arguments[0]->equals(*new_arguments[1])) | ||
| throw Exception("Cannot add aggregate states of different functions: " | ||
| + new_arguments[0]->getFunctionName() + " and " + new_arguments[1]->getFunctionName(), ErrorCodes::CANNOT_ADD_DIFFERENT_AGGREGATE_STATES); |
There was a problem hiding this comment.
The error message will be misleading when you try to add uniqUpTo(5) and uniqUpTo(10).
| throw Exception("Cannot add aggregate states of different functions: " | ||
| + new_arguments[0]->getFunctionName() + " and " + new_arguments[1]->getFunctionName(), ErrorCodes::CANNOT_ADD_DIFFERENT_AGGREGATE_STATES); | ||
|
|
||
| if (!new_arguments[0]->getReturnType()->equals(*new_arguments[1]->getReturnType().get())) |
There was a problem hiding this comment.
Why do we need this check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en