Decimal improvements #3047
Merged
Decimal improvements #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -131,23 +131,14 @@ class DataTypeDecimal final : public DataTypeSimpleSerialization | |||
| bool isParametric() const override { return true; } | |||
| bool haveSubtypes() const override { return false; } | |||
| bool shouldAlignRightInPrettyFormats() const override { return true; } | |||
| bool textCanContainOnlyValidUTF8() const override { return true; } | |||
There was a problem hiding this comment.
I cannot find the replacement.
textCanContainOnlyValidUTF8 - that is true for decimal.
| bool canBeUsedInBooleanContext() const override { return true; } | ||
| bool isNumber() const override { return true; } | ||
| bool isInteger() const override { return false; } |
There was a problem hiding this comment.
Too much cases where isNumber() means something more then expected.
In example, when isNumber enabled it leads to compareAt() for Decimals with different scales in some cases.
|
|
||
| bool isUUID() const { return idx == TypeIndex::UUID; } | ||
| bool isArray() const { return idx == TypeIndex::Array; } | ||
| bool isTuple() const { return idx == TypeIndex::Tuple; } |
There was a problem hiding this comment.
Now you have to replace typeid_casts, checkDataType across all the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en