Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClickHouse-3935 Fix bug with qualified columns in where clause #2994

Merged
merged 5 commits into from
Aug 30, 2018
Merged

ClickHouse-3935 Fix bug with qualified columns in where clause #2994

merged 5 commits into from
Aug 30, 2018

Conversation

CurtizJ
Copy link
Member

@CurtizJ CurtizJ commented Aug 29, 2018

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@@ -0,0 +1,2 @@
SELECT concat(func.name, comb.name) FROM system.functions AS func CROSS JOIN system.aggregate_function_combinators AS comb WHERE func.is_aggregate LIMIT 5;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use synthetic tables, because these tables will be extended and test result would not be stable.
(And now the result is dependent on hash function because you forgot ORDER BY)

@alexey-milovidov alexey-milovidov merged commit b05c62b into ClickHouse:master Aug 30, 2018
@alexey-milovidov
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants