Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip object fields on json input #2958

Merged
merged 3 commits into from
Aug 27, 2018

Conversation

blahgeek
Copy link
Contributor

Fixes #2367

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@alexey-milovidov
Copy link
Member

👍

@alexey-milovidov alexey-milovidov merged commit 98148d9 into ClickHouse:master Aug 27, 2018
@kmatt
Copy link

kmatt commented Sep 5, 2018

Built stable with this PR, and while it skips undefined columns from JSON messages in a Kafka consumer table, adding a materialized view from the consumer to a shard table starts the following to be logged. Uncertain if this is from the PR, or another issue:

2018.09.05 15:46:10.769379 [ 21 ] <Error> void DB::StorageKafka::streamThread(): Code: 49, e.displayText() = DB::Exception: Attempt to attach to nullptr thread group, e.what() = DB::Exception, Stack trace:

0. clickhouse-server(StackTrace::StackTrace()+0x16) [0x54b10a6]
1. clickhouse-server(DB::Exception::Exception(std::string const&, int)+0x1f) [0x290fc7f]
2. clickhouse-server(DB::ThreadStatus::attachQuery(std::shared_ptr<DB::ThreadGroupStatus> const&, bool)+0x43a) [0x4e53b3a]
3. clickhouse-server(DB::CurrentThread::attachTo(std::shared_ptr<DB::ThreadGroupStatus> const&)+0x26) [0x4e53c36]
4. clickhouse-server(DB::ParallelInputsProcessor<DB::UnionBlockInputStream<(DB::StreamUnionMode)0>::Handler, (DB::StreamUnionMode)0>::thread(std::shared_ptr<DB::ThreadGroupStatus>, unsigned long)+0x5a) [0x4de0aea]
5. clickhouse-server(std::thread::_State_impl<std::thread::_Invoker<std::tuple<DB::ParallelInputsProcessor<DB::UnionBlockInputStream<(DB::StreamUnionMode)0>::Handler, (DB::StreamUnionMode)0>::process()::{lambda()#1}> > >::_M_run()+0x40) [0x4de1120]
6. clickhouse-server() [0x5dec3af]
7. /lib64/libpthread.so.0(+0x7e25) [0x7ff5057c7e25]
8. /lib64/libc.so.6(clone+0x6d) [0x7ff504fe7bad]

@alexey-milovidov
Copy link
Member

It's not related to this PR.

And the branch stable doesn't contain any features related to ThreadStatus, CurrentThread, etc. It looks like you have built master or testing version.

@kmatt
Copy link

kmatt commented Sep 6, 2018

@alexey-milovidov Thanks. I rebuilt from a clean v18.12.3-testing without applying the PR and get the same exception.

@alexey-milovidov
Copy link
Member

The fix 5a096ee is from 18.12.5. I recommend to install latest testing, currently it is 18.12.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants