Additional higher order functions to work with arrays #2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dbms/cmake/version.cmake
VadimPlh
reviewed
Aug 28, 2018
There was a problem hiding this comment.
Hi, thanks for your PR!
- Could you add tests, please? (You can see examples here and tutorial here )
- Delete ci/default-config from your pr.
- Please, add info about new functions to the beginning of the file.
- On this simple test
SELECT arrayDifference([0, 100, 2])result is [0,100,18446744073709551518]. I think the result ofarrayDifference()should always be a sign.
|
Do you have a time to do the required modifications? |
|
#3009 Fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
I added couple functions to work with arrays, as i found no way to implement the functionality using the provided array functions.
cumulative sum with limit ( if acc value less than 0, zero is accumulated ). Ideal solution would be to implement a reduce function, which accepts 2 parameters - array and accumulating value, but i fail to program so far
difference between values in array. This could be implemented using mapArray and couple other functions, but this will be nice to do in one call