ISSUES-2906 support join for table function #2907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang2014
force-pushed
the
feature/support_join_for_table_function
branch
2 times, most recently
from
9771371 to
7499196
Compare
| select_expression_list->children.reserve(columns.size()); | ||
| if (function) | ||
| { | ||
| const auto & storage = const_cast<Context *>(&context)->executeTableFunction(table_expression); |
There was a problem hiding this comment.
That looks suspicious.
We need to either make function executeTableFunction const or figure out why it is non const and maybe change context in Expression analyzer to non-const and proove that nobody rely on it being const.
There was a problem hiding this comment.
👍
Indeed, the correct way to call it is context->getQueryContext()->executeTableFunction. Because executeTableFunction method always cache the current execution results. direct call to context->executeTableFunction could be a memory leak.
There was a problem hiding this comment.
zhang2014
force-pushed
the
feature/support_join_for_table_function
branch
from
7499196 to
83ceeca
Compare
|
Ok. PS. Non-obvious usage of Context remains as technical debt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2906
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en