ISSUES-2850 add dependencies for system tables #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| dependencies_name_array.reserve(dependencies.size()); | ||
| for (const auto & dependency : dependencies) | ||
| dependencies_name_array.push_back(dependency.first + "." + dependency.second); |
There was a problem hiding this comment.
Names are unquoted.
Concatenation leads to unstructured data.
Better to have two columns: dependencies_database, dependencies_table:
(arrays of identical sizes).
zhang2014
force-pushed
the
feature/add_dependies_for_system_tables
branch
2 times, most recently
from
9ecd5c3 to
edd7af0
Compare
zhang2014
force-pushed
the
feature/add_dependies_for_system_tables
branch
from
edd7af0 to
d766d4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2850
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en