ISSUES-2786 fix replace asterisk with join query #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang2014
force-pushed
the
fix/replace_asterisk
branch
2 times, most recently
from
f125da2 to
cf294e4
Compare
| all_columns_name.insert(all_columns_name.begin(), columns_name.begin(), columns_name.end()); | ||
|
|
||
| NameSet joined_columns; | ||
| collectJoinedColumns(joined_columns); |
There was a problem hiding this comment.
It's better not to call collectJoinedColumns from here because it has side effects.
Actually, we need only columns_from_joined_table. It's created in collectJoinedColumns method, and this code may be extracted to AnalyzedJoin's member function. Also, it's better to add bool flag in order to check that columns_from_joined_table won't be calculated twice.
There was a problem hiding this comment.
I can try to finish this part of the work : )
|
Could you please also provide a setting to turn on old behaviour for compatibility? |
zhang2014
force-pushed
the
fix/replace_asterisk
branch
3 times, most recently
from
26c7565 to
da4e036
Compare
|
Almost done @alexey-milovidov @KochetovNicolai |
zhang2014
force-pushed
the
fix/replace_asterisk
branch
from
626f7de to
ecb916d
Compare
zhang2014
force-pushed
the
fix/replace_asterisk
branch
from
ecb916d to
741abc2
Compare
zhang2014
referenced
this pull request
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2786
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en