CLICKHOUSE-3714 add max_partition_size_to_drop #2782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,6 +129,20 @@ bool StorageMergeTree::checkTableCanBeDropped() const | |||
| return true; | |||
| } | |||
|
|
|||
| bool StorageMergeTree::checkPartitionCanBeDroppedDetachReplace(const ASTPtr & partition) | |||
| { | |||
| const_cast<MergeTreeData &>(getData()).recalculateColumnSizes(); | |||
dbms/src/Interpreters/Context.cpp
Outdated
|
|
||
| ostr << "Partition in table " << backQuoteIfNeed(database) << "." << backQuoteIfNeed(table) << " was not dropped.\n" | ||
| << "Reason:\n" | ||
| << "1. Partition size (" << partition_size_str << ") is greater than max_table_size_to_drop (" << max_partition_size_to_drop_str << ")\n" |
| table->checkPartitionCanBeDropped(command.partition); | ||
| String from_database = command.from_database.empty() ? context.getCurrentDatabase() : command.from_database; | ||
| auto from_storage = context.getTable(from_database, command.from_table); | ||
| table->replacePartitionFrom(from_storage, command.partition, command.replace, context); |
| const String partition_id = data.getPartitionIDFromQuery(partition, context); | ||
| auto parts_to_remove = data.getDataPartsVectorInPartition(MergeTreeDataPartState::Committed, partition_id); | ||
|
|
||
| for (const auto & part : parts_to_remove) |
There was a problem hiding this comment.
Partition is a set of parts. And the size of partition must be considered in total.
| const String partition_id = data.getPartitionIDFromQuery(partition, context); | ||
| auto parts_to_remove = data.getDataPartsVectorInPartition(MergeTreeDataPartState::Committed, partition_id); | ||
|
|
||
| for (const auto & part : parts_to_remove) |
alexey-milovidov
added a commit
that referenced
this pull request
Aug 6, 2018
|
You forgot about config.xml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en