CLICKHOUSE-3832: Add HTTP Basic authentification in replication protocol #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbms/programs/server/Server.cpp
Outdated
| String password = config().getString("interserver_http_credentials.password", ""); | ||
|
|
||
| if (user.empty()) | ||
| throw Exception("Empty interserver_http_credentials user can't be empty"); |
dbms/programs/server/Server.cpp
Outdated
| @@ -230,6 +230,17 @@ int Server::main(const std::vector<std::string> & /*args*/) | |||
| global_context->setInterserverIOAddress(this_host, port); | |||
| } | |||
|
|
|||
| if (config().has("interserver_http_credentials.user")) | |||
There was a problem hiding this comment.
Maybe config().has("interserver_http_credentials") is better.
| @@ -65,8 +92,18 @@ void InterserverIOHTTPHandler::handleRequest(Poco::Net::HTTPServerRequest & requ | |||
|
|
|||
| try | |||
| { | |||
| processQuery(request, response); | |||
| LOG_INFO(log, "Done processing query"); | |||
| if (auto [msg, success] = checkAuthentication(request); success) | |||
There was a problem hiding this comment.
msg is unused.
... or is it visible in else?
There was a problem hiding this comment.
it's visible inside else branch.
… change check for interserver_http_credentials
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en