-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLICKHOUSE-3771 Preparing for new version scheme [WIP] #2646
Conversation
eb0f0cc
to
8ee0d71
Compare
@@ -88,6 +89,7 @@ BlockInputStreams StorageSystemProcesses::read( | |||
res_columns[i++]->insert(process.client_info.client_name); | |||
res_columns[i++]->insert(process.client_info.client_version_major); | |||
res_columns[i++]->insert(process.client_info.client_version_minor); | |||
res_columns[i++]->insert(process.client_info.client_version_patch); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See also QueryLog.cpp
@@ -51,7 +51,11 @@ function gen_revision_author { | |||
VERSION_MINOR=$(($VERSION_MINOR + 1)) | |||
VERSION_PATCH=0 | |||
elif [ "$TYPE" == "patch" ] || [ "$TYPE" == "bugfix" ]; then | |||
# VERSION_REVISION not incremented. | |||
# VERSION_REVISION not incremented in new scheme. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not.
dbms/programs/server/TCPHandler.cpp
Outdated
@@ -517,15 +522,13 @@ void TCPHandler::sendHello() | |||
writeStringBinary(DBMS_NAME, *out); | |||
writeVarUInt(DBMS_VERSION_MAJOR, *out); | |||
writeVarUInt(DBMS_VERSION_MINOR, *out); | |||
// TODO: If we will broke protocol - add this field: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Client cannot send its patch version to server.
But server can send its patch version in reply for new clients.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en