CLICKHOUSE-3771 Preparing for new version scheme [WIP] #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proller
force-pushed
the
fix8
branch
2 times, most recently
from
eb0f0cc
to
8ee0d71
Compare
| @@ -88,6 +89,7 @@ BlockInputStreams StorageSystemProcesses::read( | |||
| res_columns[i++]->insert(process.client_info.client_name); | |||
| res_columns[i++]->insert(process.client_info.client_version_major); | |||
| res_columns[i++]->insert(process.client_info.client_version_minor); | |||
| res_columns[i++]->insert(process.client_info.client_version_patch); | |||
| @@ -51,7 +51,11 @@ function gen_revision_author { | |||
| VERSION_MINOR=$(($VERSION_MINOR + 1)) | |||
| VERSION_PATCH=0 | |||
| elif [ "$TYPE" == "patch" ] || [ "$TYPE" == "bugfix" ]; then | |||
| # VERSION_REVISION not incremented. | |||
| # VERSION_REVISION not incremented in new scheme. | |||
dbms/programs/server/TCPHandler.cpp
Outdated
| @@ -517,15 +522,13 @@ void TCPHandler::sendHello() | |||
| writeStringBinary(DBMS_NAME, *out); | |||
| writeVarUInt(DBMS_VERSION_MAJOR, *out); | |||
| writeVarUInt(DBMS_VERSION_MINOR, *out); | |||
| // TODO: If we will broke protocol - add this field: | |||
There was a problem hiding this comment.
Client cannot send its patch version to server.
But server can send its patch version in reply for new clients.
alexey-milovidov
added a commit
that referenced
this pull request
Jul 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en