Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce logging in shared library dictionaries #2472

Merged
merged 7 commits into from
Jun 7, 2018

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Jun 6, 2018

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

void trace(ClickHouseLibrary::CString msg)
{
auto & logger = Logger::get(DICT_LOGGER_NAME);
if (logger.trace())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no params?

auto & logger = Logger::get(DICT_LOGGER_NAME);
if (logger.trace())
{
logger.trace(msg);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

params?

}
}

void debug(ClickHouseLibrary::CString msg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use one function log(TRACE, msg) ?

@alexey-milovidov alexey-milovidov merged commit a0592aa into ClickHouse:master Jun 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants