Introduce logging in shared library dictionaries #2472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proller
reviewed
Jun 6, 2018
| void trace(ClickHouseLibrary::CString msg) | ||
| { | ||
| auto & logger = Logger::get(DICT_LOGGER_NAME); | ||
| if (logger.trace()) |
proller
reviewed
Jun 6, 2018
| auto & logger = Logger::get(DICT_LOGGER_NAME); | ||
| if (logger.trace()) | ||
| { | ||
| logger.trace(msg); |
proller
reviewed
Jun 6, 2018
| } | ||
| } | ||
|
|
||
| void debug(ClickHouseLibrary::CString msg) |
There was a problem hiding this comment.
why not use one function log(TRACE, msg) ?
…ne and add logging examples into test libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en