ISSUES-2083 fix filter required with union & subquery #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang2014
changed the title
zhang2014
force-pushed
the
fix/ISSUES-2083
branch
4 times, most recently
from
12ce7bf
to
8b53fc2
Compare
zhang2014
changed the title
zhang2014
changed the title
zhang2014
force-pushed
the
fix/ISSUES-2083
branch
3 times, most recently
from
34ffa94
to
6b8d8c3
Compare
zhang2014
force-pushed
the
fix/ISSUES-2083
branch
from
6b8d8c3
to
5d5350c
Compare
zhang2014
changed the title
| namespace DB | ||
| { | ||
|
|
||
| class CuttingUnionAllRequiredColumnBlockInputStream : public IProfilingBlockInputStream |
There was a problem hiding this comment.
No comments - don't understand.
| class CuttingUnionAllRequiredColumnBlockInputStream : public IProfilingBlockInputStream | ||
| { | ||
| public: | ||
| CuttingUnionAllRequiredColumnBlockInputStream(const BlockInputStreamPtr input_, const Names & required_columns); |
zhang2014
commented
Mar 29, 2018
| * required_columns : [X,A,X] | ||
| * output_columns : [X,A,X] | ||
| */ | ||
| class CuttingUnionAllRequiredColumnBlockInputStream : public IProfilingBlockInputStream |
There was a problem hiding this comment.
Because Interpreter cannot remove second x of second sub_union_query for
SELECT field_1,field_3,field_4 FROM (SELECT field_1,field_2,field_3,field_4 FROM table_a UNION ALL SELECT X,X,A,X FROM b);
alexey-milovidov
added a commit
that referenced
this pull request
Aug 5, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 5, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 5, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 5, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 5, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Aug 5, 2018
This reverts commit 36eae15.
alexey-milovidov
added a commit
that referenced
this pull request
Aug 5, 2018
This reverts commit 4755422.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2083
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en