feat: remove static methods for prior instance method setLang, remove default rumLogger #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
approve |
dihar
force-pushed
the
feature/add-global-lang
branch
3 times, most recently
from
a91dcfd to
86b6cf5
Compare
ogonkov
reviewed
May 24, 2022
src/index.ts
Outdated
| languageData = this.data[lang]; | ||
| } | ||
| has(keysetName: string, key: string, lang?: string) { | ||
| const languageData = this.data[lang || this.lang]; |
There was a problem hiding this comment.
Этот же паттерн ниже в i18n остался без изменений почему-то
Возможно стоит сделать (protected?) метод getLanguageData(lang: string)
dihar
force-pushed
the
feature/add-global-lang
branch
2 times, most recently
from
24e8524 to
412167c
Compare
dihar
changed the title
dihar
force-pushed
the
feature/add-global-lang
branch
2 times, most recently
from
895d0e8 to
c2d14c6
Compare
ogonkov
reviewed
May 24, 2022
dihar
force-pushed
the
feature/add-global-lang
branch
6 times, most recently
from
8d14ee5 to
f3ffefb
Compare
… default rumLogger
dihar
force-pushed
the
feature/add-global-lang
branch
from
f3ffefb to
e8e7c32
Compare
ogonkov
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove static methods for prior instance method setLang, remove default rumLogger