fix: error handling fixes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korvin89
commented
Jul 27, 2022
| @@ -12,7 +12,7 @@ export const CHARTKIT_ERROR_CODE = { | |||
|
|
|||
| export class ChartKitError extends Error { | |||
| readonly code: number | string; | |||
| readonly isChartKitError = true; | |||
| readonly isCustomError = true; | |||
There was a problem hiding this comment.
To easier compatibility with old code in DL. It will be changed to isChartKitError later
korvin89
commented
Jul 27, 2022
| @@ -20,7 +20,7 @@ export class ErrorBoundary extends React.Component<Props, State> { | |||
| error: undefined, | |||
| }; | |||
|
|
|||
| componentDidUpdate() { | |||
| componentDidCatch() { | |||
There was a problem hiding this comment.
componentDidCatch definitely invoked in case of error (unlike componentDidUpdate)
Marginy605
reviewed
Jul 27, 2022
Marginy605
approved these changes
Jul 27, 2022
This was referenced Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.