Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect handleRequestError behavior on timed out requests #17

Closed
jhoncool opened this issue Jul 4, 2022 · 0 comments · Fixed by #20 or #21
Closed

incorrect handleRequestError behavior on timed out requests #17

jhoncool opened this issue Jul 4, 2022 · 0 comments · Fixed by #20 or #21

Comments

@jhoncool
Copy link

jhoncool commented Jul 4, 2022

Hello, handleRequestError gets undefined in the first argument when request timed out on the client-side. So, we don't have access to error details.

Original axios contains some information about this kind of problems:
Снимок экрана 2022-07-04 в 11 47 41

It would also be nice to have all the information about the original error.
tsufiev added a commit that referenced this issue Jul 15, 2022
@tsufiev
fix: correctly handle errors with the missing response
a3868ed 
There is no response in case this is a timeout error.

Closes: #17
@tsufiev tsufiev mentioned this issue Jul 15, 2022
Merged
tsufiev added a commit that referenced this issue Jul 15, 2022
@tsufiev
fix: correctly handle errors with the missing response
6b9dc0e 
There is no response in case this is a timeout error.

Closes: #17
@yc-ui-bot yc-ui-bot mentioned this issue Jul 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jhoncool