Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set up rl-human-prefs #4

Closed
yamatokataoka opened this issue Dec 20, 2021 · 5 comments · Fixed by #9
Closed

set up rl-human-prefs #4

yamatokataoka opened this issue Dec 20, 2021 · 5 comments · Fixed by #9
Assignees
@yamatokataoka
Milestone
v0.1.0 MVP

Comments

@yamatokataoka
Copy link
Owner

yamatokataoka commented Dec 20, 2021 •
edited
Loading

  • add Python project
  • set up linter, type checker
@yamatokataoka yamatokataoka added this to the v0.0.1 MVP milestone Dec 20, 2021
@yamatokataoka yamatokataoka moved this from Todo to In Progress in learning-from-human-preferences Dec 28, 2021
@yamatokataoka yamatokataoka self-assigned this Dec 28, 2021
@yamatokataoka
Copy link
Owner Author

poetry would be good option for sophisticated dependency management

https://mitelman.engineering/blog/python-best-practice/automating-python-best-practices-for-a-new-project/#fast-track

@yamatokataoka
Copy link
Owner Author

yamatokataoka commented Jan 15, 2022 •
edited
Loading

poetry with Docker
python-poetry/poetry#1879 (comment)

I don't use Docker because we can't run Docker on Colab and isolation of environment would be enough with poetry and its venv.

@yamatokataoka
Copy link
Owner Author

linters

  • isort
  • black
  • flake8
  • mypy

@yamatokataoka
Copy link
Owner Author

pyproject.toml
https://martin-thoma.com/pyproject-toml/

@yamatokataoka
Copy link
Owner Author

poetry with tox
python-poetry/poetry#1941

@yamatokataoka yamatokataoka linked a pull request Jan 29, 2022 that will close this issue
set up rl-human-prefs #9
Merged
Repository owner moved this from In Progress to Done in learning-from-human-preferences Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yamatokataoka yamatokataoka

Labels
None yet
Projects
learning-from-human-preferences
Status: Done
Milestone
v0.1.0 MVP
Development

Successfully merging a pull request may close this issue.

set up rl-human-prefs yamatokataoka/learning-from-human-preferences
1 participant
@yamatokataoka