Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rating): backport from angular-ui/bootstrap, now using ngModel #255

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(rating): backport from angular-ui/bootstrap, now using ngModel #255

wants to merge 3 commits into from

Conversation

kralo
Copy link

@kralo kralo commented Aug 27, 2015

possibly adressing #238

foundation update due to .show-for-sr (foundation/foundation-sites@7bb9efc)

BREAKING CHANGE: rating is now integrated with ngModelController.

  • value is replaced from ng-model.

    Before:

    <rating value="rate" ...></rating>

    After:

    <rating ng-model="rate" ...></rating>

@jbrowning
Copy link
Member

Thanks for sending this in @kralo. Integrating with ngModel makes sense to me. Please merge in master and resolve conflicts.

@kralo
Copy link
Author

kralo commented Oct 19, 2015

@jbrowning updated the gruntfile, please have a look again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kralo @jbrowning