This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
loader metadata per lang #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etc across the board. fixing css metadata.
|
More work to be done on this. |
…evel, and also logLevelOrder to modify the default value.
…y lang meta if controller is not common of client. passing request lang as part of the seed url.
…r html5apps running on cocktails runtime
…s part of the metadata resolution to avoid mixing server and client side dependencies. adding request as a dependency due to the nature of yui-sandbox implementation.
| @@ -46,6 +47,10 @@ var libfs = require('fs'), | |||
| MODULE_META_PRIVATE_ENTRIES = ['after', 'expanded', 'supersedes', 'ext', '_parsed', '_inspected', | |||
| 'skinCache', 'langCache'], | |||
|
|
|||
| REGEX_LANG_TOKEN = /\"\{langToken\}\"/g, | |||
| REGEX_LANG_PATH = /\{langPath\}/g, | |||
| REGEX_LOCALE = /\_([a-z]{2}-[A-Z]{2})$/, | |||
There was a problem hiding this comment.
Do we need to watch for simple 'en' or 'de' here?
There was a problem hiding this comment.
good point, I will generalize that.
|
Other than optional nits, +1 |
caridy
added a commit
that referenced
this pull request
Oct 12, 2012
loader metadata per lang - new centralized configuration through application.json->yui->config for loader on server, loader on client, combo handler and application in general. - new experimental yui-sandbox to be able to isolate processes (like client side metadata computation) - enhance loader-app-base and loader-app-full to be lang aware for performance reasons - define a way to configure the metadata url through application.json->yui-config->url
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
application.json->yui->configfor loader on server, loader on client, combo handler and application in general.loader-app-baseandloader-app-fullshould be lang aware for performance reasons