-
Notifications
You must be signed in to change notification settings - Fork 214
Added support for /robots.txt and fixed JSLint errors #565
Conversation
Should mojito be smart enough to generate robots and manifest files? I do think that we should be able to redefine/force specific files though, so I will give it a +1 |
You could instead have a route for I'd prefer a solution that allows that to happen, but we can go with this for now, and tweak it later. |
Ok, I will merge this, and we can plan for having some sort of npm bundle to add support for robots and manifest that can be plugged into the apps by just adding them as dependencies. |
Ops, I just noticed the error msg in travis about the |
@caridy afaik we're using the version in npm and hence the todo flag isn't supported until that package is updated from a jslint version which supports it. |
We should also add support for crossdomain.xml... Caridy, can you add that one line, or do you need a new pull request? |
@jlecomte u can commit that line under the same PR, and it will be aggregated automatically once u push to your branch. |
Ok, this is ready to be merged. I will hold it until I finish the update of node-jslint pkg to support |
@jlecomte is it ok to remove the "todo:true"? I don't see js error from "mojito jslint" command after it is removed. |
Eventually, this should be done using new, special routes...