Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

[bz4788267] Child errors are not communicated clearly to parents #25

Closed
add0n opened this issue Mar 30, 2012 · 2 comments
Closed

[bz4788267] Child errors are not communicated clearly to parents #25

add0n opened this issue Mar 30, 2012 · 2 comments

Comments

@add0n
Copy link
Contributor

add0n commented Mar 30, 2012

The default error() function the composite plugin uses to handle child errors looks like this:

        error: function(err) {
            Y.log("Error executing child mojit at '" + this.id + "':", 'error', NAME);
            Y.log(err.message, 'error', NAME);
            Y.log(err.stack, 'error', NAME);
            // Pass back some empty data so we don't fail the composite
            this.done('');
        }

In order to allow the parent mojit to continue running, it passes back an empty string into ac.done(), but we should have a way to communicate child errors

@caridy
Copy link
Contributor

caridy commented Jan 29, 2013

This is still an issue. Let's bump this up. /cc @rwaldura @jenny

caridy added a commit that referenced this issue Feb 20, 2013
Fixes issue #865. Fixes issue #25: `mojito-composite-addon` error propagation by flagging a child with `propagateFailure` flag.
@caridy
Copy link
Contributor

caridy commented Feb 20, 2013

will be available in [email protected] scheduled for next week.

@caridy caridy closed this as completed Feb 20, 2013
@caridy caridy removed this from the v0.5.5 milestone Mar 3, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants