Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid sparse fields leads to service 500 for Aggregation Store queries. #1779

Closed
aklish opened this issue Jan 21, 2021 · 0 comments · Fixed by #1801
Closed

Invalid sparse fields leads to service 500 for Aggregation Store queries. #1779

aklish opened this issue Jan 21, 2021 · 0 comments · Fixed by #1801
Assignees
@rishi-aga

Comments

@aklish
Copy link
Member

aklish commented Jan 21, 2021

An invalid query like:

/factTable?fields[factTable]=foo?sort=-foo

will generate a 500 error.

Expected Behavior

The service should detect the invalid field and return a 400 error.

Possible Solution

While this could be fixed in the AggregationStore, it should be fixed in the JSON-API handling of sparse fields.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishi-aga rishi-aga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue#1779 Invalid sparse fields should return 4xx yahoo/elide
2 participants
@aklish @rishi-aga