Downloading PHPUnit twice ?

[jrfnl]

Just wondering - I might well be reading the code incorrectly -, but by the looks of it, PHPUnit is potentially downloaded & installed twice ?

There may be an efficiency fix which can be made here or else a de-duplication.

wp-dev-lib/travis.install.sh

Lines 14 to 19 in 61a4add

	mkdir -p $HOME/phpunit-bin/$PHPUNIT_VERSION
	echo "Opting for phpunit $PHPUNIT_VERSION for PHP $TRAVIS_PHP_VERSION"
	export PATH="$HOME/phpunit-bin/$PHPUNIT_VERSION:$PATH"
	if [[ ! -e $HOME/phpunit-bin/$PHPUNIT_VERSION/phpunit ]]; then
	wget -O $HOME/phpunit-bin/$PHPUNIT_VERSION/phpunit https://phar.phpunit.de/phpunit-$PHPUNIT_VERSION.phar
	chmod +x $HOME/phpunit-bin/$PHPUNIT_VERSION/phpunit

wp-dev-lib/check-diff.sh

Lines 444 to 447 in 61a4add

	PHPUNIT_VERSION=${PHPUNIT_VERSION:-5.7}
	echo "Downloading PHPUnit $PHPUNIT_VERSION phar"
	download https://phar.phpunit.de/phpunit-$PHPUNIT_VERSION.phar "$TEMP_TOOL_PATH/phpunit"
	chmod +x "$TEMP_TOOL_PATH/phpunit"

[kasparsd]

Fixed in #301.

[jrfnl]

🎉