Skip to content
This repository has been archived by the owner on Nov 10, 2022. It is now read-only.

Broken Coveralls support? #152

Closed
ocean90 opened this issue Mar 13, 2016 · 4 comments
Closed

Broken Coveralls support? #152

ocean90 opened this issue Mar 13, 2016 · 4 comments

Comments

@ocean90
Copy link
Contributor

ocean90 commented Mar 13, 2016

In 13db3de support for Coveralls was added.

Today I tried to include the file in the repo for GlotPress via GlotPress/GlotPress@2b79c98 and GlotPress/GlotPress@a0045d0, but it seems like the config file is now longer valid, see https://travis-ci.org/GlotPress/GlotPress-WP/builds/115695816.

I took a look at another repo and found xwp/wp-customize-posts@a7fa4f5 which doesn't include the line src_dir: ..
Should this be changed in the default .coveralls.yml file?

@westonruter
Copy link
Contributor

Good question. I actually don't recall symlinking to the .coveralls.yml file but instead copying it along with the .travis.yml. But to be honest, I only have a limited familiarity with Coveralls.

@valendesigns Should the src_dir be removed?
@ocean90 In the mean time, if you copy the file instead of symlink, does it then work?

@ocean90
Copy link
Contributor Author

ocean90 commented Mar 13, 2016

I haven't tested that, but it looks like the option got removed in 1.0.0, see https://github.com/satooshi/php-coveralls/blob/master/CHANGELOG.md#100.

@aristath
Copy link

I struggled getting coveralls to play nicely with my repos as well and in the end I just went for codecov instead. It's simpler and tbh it's also a lot better... You can even see the coverage on github directly 👍 https://github.com/codecov/browser-extension

@ocean90
Copy link
Contributor Author

ocean90 commented Mar 13, 2016

Well, coveralls works without the src_dir value, but I agree that codecov looks much better.

Maybe provide a flag do decide which service should be used for coverage?

Example Project: https://codecov.io/github/WP-API/WP-API?branch=develop
Example Config: https://github.com/codecov/example-php/blob/master/.travis.yml

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants