Skip to content
This repository has been archived by the owner on Aug 24, 2018. It is now read-only.

video looping #130

Open
soderlind opened this issue May 5, 2017 · 11 comments · Fixed by #136
Open

video looping #130

soderlind opened this issue May 5, 2017 · 11 comments · Fixed by #136

Comments

@soderlind
Copy link

Adding a youtube video without doing any changes. Playing it, it loops at the end of the video.
If I edit the video and check "loop", it doesn't loop anymore, not even if I uncheck/check and save multiple times.

@timmyc
Copy link
Contributor

timmyc commented May 5, 2017

totally not related to the bug report, but that cover/video is amazing 😮 !!

@timmyc timmyc added the bug label May 5, 2017
@timmyc
Copy link
Contributor

timmyc commented May 5, 2017

Was able to reproduce with multiple videos - the same experience is not encountered when embeding via the editor either.

@timmyc
Copy link
Contributor

timmyc commented May 5, 2017

So debugging a bit more, it seems to only be affecting YouTube videos. Embedding a Vimeo video ( I used https://vimeo.com/190372437 ) and upon playing the video it did not loop.

@soderlind
Copy link
Author

<offtopic>
AURORA has also done a cover of "Half the World Away" by Oasis .. and thanks for pointing me to Frightened Rabbit :)
</offtopic>

@timmyc
Copy link
Contributor

timmyc commented May 5, 2017

Love the 🎵 angle on this issue!

Anyhow, wanted to update the original issue here that the YouTube looping issue appears to be a bug in the underlying mediaelement library version in use in core - details and more discussion on the PR #136 (comment)

@westonruter
Copy link
Contributor

Re-opening because YouTube is not fixed yet, which apparently depends on https://core.trac.wordpress.org/ticket/39686

@westonruter westonruter reopened this May 5, 2017
@rafa8626
Copy link

rafa8626 commented May 6, 2017

Is there a sandbox where I can see this issue and assist you to fix this please? Is this for 4.x version?

@westonruter
Copy link
Contributor

@rafa8626 just install this plugin from GitHub.

@rafa8626
Copy link

rafa8626 commented May 7, 2017

Once installed is that all I need to do? Excuse my lack of knowledge in Wordpress

@rafa8626
Copy link

rafa8626 commented May 8, 2017

I tried to add a YouTube video through the Add Media button, but when I paste the URL it has all YouTube styles, not MediaElement. Should I be doing this that way? If not, please indicate how so I can assist you and continue to move towards 4.x version. BTW, is this issue on 4.x version, or on 2.x version?

@rafa8626
Copy link

rafa8626 commented May 9, 2017

I have submitted a patch on Wordpress ticket. Can you integrate it on your branch and confirm it's fixed, please?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants