The file types upload are not restricted according to the Widget type

[miina]

It's possible to set an image to video/audio widget etc. Will be displayed as links / broken image.

[westonruter]

To clarify: this is during the upload flow. The media browser does successfully restrict the file types, but the upload UI currently is not.

[melchoyce]

Is this fixable?

[timmyc]

I suppose we could do some extension testing in the selection callback to ensure we have a valid extension per the widget. Kind of feels like the media modal should prevent this though.

[westonruter]

There should be a parameter to pass to the upload state to restrict the type.

[westonruter]

Hummm. This seems like it may actually be a core bug. For example, if you go into edit a post, and you open the media modal to select a featured image. From this screen, you can go to upload a video and then select it. That shouldn't be possible.

[Presskopp]

FYI, there's a related ticket:
https://core.trac.wordpress.org/ticket/39625

[westonruter]

I can see the full list of MIME types when I look at wp.media.frame.uploader.uploader.uploader.settings.filters.mime_types. I'm not sure how to properly override it, however.

[westonruter]

I'm not the only one to ask the question: http://stackoverflow.com/questions/38400352/plupload-change-mime-type-filter-after-init

[westonruter]

Looks like there is a bug in Plupload affecting the ability to change the file filter after init: moxiecode/plupload#1339

[joemcgill]

I've been digging into this issue a bit but haven't had time to code a solution yet. However, thought it might help to leave some initial thoughts.

All of the supported mime types get passed to plupload via _wpPluploadSettings when the Uploader is created. As far as I can tell, each frame gets a unique Plupload instance, so we could potentially reach in and change the supported mime types when the uploader is added to the view, but that seems dirty.

My current idea would be to try extending the wp.media.controller.Library during state creation so you could add a mime type check on the upload callback that happens here.

Regardless, I don't see this as a blocker for merge, since the same issue exists currently any time media frame is created.