Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

[Gutenberg] Build a "Featured Destinations" block for Homepage #25

Open
postphotos opened this issue Apr 3, 2018 · 8 comments
Open
Assignees

Comments

@postphotos
Copy link

part of the components listed in #12.

As requested (and detailed) by @miina here.

Mockups are available here:

Some notes from #9 apply here:

Would be used for the display post (next to "Discover Adventures"), for Top Adventures Near You;
Would have controls to choose:
How many posts to show;
Which category posts to show;
How to sort (e.g. by meta value X);
Layout / or which fields to display.
For example for the post next to "Discover Adventures" you could choose layout A; 1 post; category "Food", for the the Top Adventures Near You" could choose layout B; 3 posts; category "Adventure"; sort by meta value Review;
Question: Does this make sense for these two sections from the editor's point of view?

Category/taxonomy list block:
Would be used for "Browse by activity" and "Featured destinations";
Would have option to choose which fields to display (e.g. meta value such as icon / background image; count of posts
Option to choose how many categories to display;
Perhaps option to filter by "featured"
Option to sort by ... ?

@miina
Copy link
Contributor

miina commented Apr 4, 2018

See Weston's comment on the possible approach: https://xwp.slack.com/archives/C75JEPFDZ/p1522856822000257

Let a user upload a photo of any dimensions. If it is a portrait photo, try to display it in the grid as a portrait slot. If that's not possible, then allow a landscape photo to be cropped to portrait dimensions.
The block could try sorting the destinations so that the photos are sorted as (1 portrait|2 landscape)+
But then otherwise fallback to forcing a portrait to be rendered in a landscape slot if otherwise not available.

@postphotos
Copy link
Author

Hi @miina, I'll turn this into real ACs shortly, but just dropping in from yesterday's meeting.

Featured Destinations
- taxonomy checkbox
- Popular rating
- edit page of a term for location
- upload image in term page

@miina miina self-assigned this Apr 5, 2018
@DavidCramer DavidCramer self-assigned this Apr 6, 2018
@kienstra
Copy link
Contributor

kienstra commented Apr 11, 2018

Moving To "QA" Column

The "Featured Destinations" block was part of the merged PR #13. So I'm moving this issue into the "QA" column.

@miina
Copy link
Contributor

miina commented Apr 12, 2018

@kienstra This ticket actually has a separate PR as well which is currently still WIP: #34. What #13 included was displaying static block, however as far as I understand, this ticket is for pulling the content dynamically and is still in process.

@kienstra
Copy link
Contributor

kienstra commented Apr 12, 2018

Thanks for clarifying that, @miina. I moved this back to "In progress."

@kienstra
Copy link
Contributor

Request For Testing

Hi Claudio,
Could you please test this block?

  1. Create a new page
  2. Add a "Featured Destinations" block

add-featured-dest

Expected:

  • It matches the design for desktop and mobile
  • It's responsive in the editor and the front-end
  • The heading is editable:

featured-dest-editable

@csossi
Copy link

csossi commented May 10, 2018

Background image not appearing in IE11:
image

@kienstra
Copy link
Contributor

kienstra commented May 11, 2018

Question About Images

Hi @csossi,
Thanks for testing this. Could you elaborate on "background image not appearing"?

IE11: http://dev-amp-start-travel.pantheonsite.io/
bs_win10_ie_11 0

@kienstra kienstra assigned csossi and unassigned DavidCramer and miina May 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants