-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X3: Volume level for both jack sockets independently #1
Comments
The line out should have 100% volume with no volume limit, and jack output should be limited according to user setting. The tricky part is to cleverly detect which cable is plugged, and the headphone jack should have precedence in order to avoid 100% volume on headphone jack at all costs. Currently it's a pain to have to disable volume limit, set volume to 100% manually when using line out, and having to do things the other way around when switching back. |
I've been looking at this today and can't really progress because I'm missing the block diagram of the device. The source code seems to point at GPIO 44 as the line out detect, but on my device plugging/unplugging the line out connector triggers the same results as the headphone jack. Not sure how this is implemented in the original firmware. Anyone cared to ask XDuoo for the kernel source code (if they use Linux then it's an obligation for them to release source code and build tools) ? |
Thanks for looking at this.. Personally I don't have a contact to any of developers.. This is first place I went with this. Also I think equalizer settings should stick to the phones output, but for the line output equalizer and other additional parameters should be reset to zero. What do you think? |
…ntext Selective backlight allows the user to choose actions that will not enable the backlight when pressed. Advanced softlock allows user to choose actions that will not be blocked by screenlock on devices without a hold button. Both only occur in FM and WPS Contexts. Update: Back from the dead -Cleaned up code, removed unnecessary calls, re-arranged last filter action timeout conditional to work in case last_filtered_action_tick was never set -Added entries to the manual -Fixed back button on some menus not activating backlight -Made menus more intuitive, no actions selected now changes menu item to off. -Added talk fuctionality. -Added option to disable selective backlight while on external power. -Rewrote backlight and softlock handling code to fix issue with scrollwheels -Menu changed to have toggle(yes/no) and settings -Optimized selective actions lookup -Added option to disable notification of 'buttons locked' while softlocked -Removed uneeded code, consolidated action lookup to single function -Fixed incorrect name on selective softlock menu -Added option to disable touch on touchscreen devices -Fixed backlight on original screenlock without selective screenlock active -Added text selection in mask_select for when show_icons is off -Fixed voice in mask_select to speak if voice is defined instead of spelling -Added more lang defines (play skip seek) -Added option to disable unknown keys turning on backlight -Fixed Conditional argument In wrong place causing players without backlight to fail to build -Fixed Disable Unknown blocking detection of context change -Fixed canceling menu didn't update new settings -Added Autolock on backlight off -Removed backlight_on_force from backlight.c, Now sets ignore next to false and uses backlight_on -Cleaned up autolock code added strings to lang file -Fixed issue where rapid presses would bypass softlock -Removed old softlock code, Cleaned selective actions code -Changed menu to match existing RB menus -Fixed Backlight_on_Hold blocked by backlight_ignore_next -Fixed ignore_next for ipod -Fixed bug allowing context with softlock to bypass selective backlight -Changed mask_select to no longer prompt for changes to be saved -Changed menu names -Added ignore timeout to allow ipod scroll wheel to work properly and other players to still work properly, removed some previous code including ignore_event -Increased ignore timeout to prevent sd card accesses from interrupting action code and turning on backlight -Changed Unknown action to unmapped action in menu, changed handling code -Removed unneeded logic and variables for handling unfiltered actions -Reverted unmapped action code to previous functionality -Added manual entries (thanks JohnB) -Removed elusive unhandled unicode character from manual, changed formatting slightly Actions: Volume,Play,Seek,Skip Extras: Disable unmapped actions Disable selective backlight on external power Disable touch during softlock on touchscreen devices Disable softlock notifications (power button still notifies) Autolock on backlight off Method: Adds a function to ignore backlight on next call If selected action occurs backlight is forced on, Filter_first_keypress stays intact. Selective softlock allows selected actions through, bypasses the normal softlock routine. ToDo: DONE previous commit (#1) has attribution for folder_select.c which mask_select is based from. Change-Id: I08132ddcfd64c81751ef23b720f3ec6d68695fe4
Hi!
First of all thank you so much for making Rockbox available for xduoo x3! I really appreciate it.
As we know X3 has two jack output sockets, for headphones and line-out. Original software keeps volume information for both sockets independently, when you use headphone socket you get last used volume level for headphones and for line-out you get simply 100 volume level.
Current version of Rockbox use the same volume value for both, which can be pretty painful - being in a car I use line-out with 100% volume level but then when I switch to headphone socket I can forget that last used volume level is 100% and them my ears start bleeding from that loudness. This is pretty dangerous.
Do you think you could make Rockbox remembering last headphone volume level and switch to that value once jack plug is inserted back to headphone socket, and for line-out socket is it possible to fix a value with 100%?
Thank you once again and kind regards,
K
The text was updated successfully, but these errors were encountered: