Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing an object to an interface isn't necessarily breaking #32

Open
eapache opened this issue Sep 30, 2020 · 2 comments
Open

Changing an object to an interface isn't necessarily breaking #32

eapache opened this issue Sep 30, 2020 · 2 comments

Comments

@eapache
Copy link
Contributor

eapache commented Sep 30, 2020

"the type changed" is almost always a breaking change, except when going from an object to an interface with exactly the same set of fields (and implemented interfaces). It would be nice if schema_comparator recognized this case and didn't flag it as breaking.

@jturkel
Copy link
Contributor

jturkel commented Aug 4, 2021

Perhaps this should be a dangerous change since clients will get different results if they're selecting __typename for this object/interface?

@swalkinshaw
Copy link
Collaborator

Oh good point! Since the interface would return the resolved object type's name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants