Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New unicode-graphemes addon. #4519

Merged
merged 62 commits into from
Sep 12, 2023
Merged

New unicode-graphemes addon. #4519

merged 62 commits into from
Sep 12, 2023

Commits on May 17, 2023

  1. New unicode-graphemes addon. 

    Handle grapheme cluster lookup as well as wcwidth.
This is based on Unicode 15, and could replace the unicode11 addon.
    @PerBothner
    PerBothner committed May 17, 2023
    Configuration menu
    Copy the full SHA
    2f7fe11 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Cleanup - fix various tests.

    @PerBothner
    PerBothner committed May 18, 2023
    Configuration menu
    Copy the full SHA
    67e9689 View commit details
    Browse the repository at this point in the history

  2. xterm-addon-unicode-graphemes - fix 'yarn test'

    @PerBothner
    PerBothner committed May 18, 2023
    Configuration menu
    Copy the full SHA
    41760df View commit details
    Browse the repository at this point in the history

  3. xterm-addon-unicode-graphemes: add api tests and get demo working

    @PerBothner
    PerBothner committed May 18, 2023
    Configuration menu
    Copy the full SHA
    8e730cd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored May 18, 2023
    Configuration menu
    Copy the full SHA
    9c34bb4 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. patch for working perf test and API test injection

    @jerch
    jerch committed May 20, 2023
    Configuration menu
    Copy the full SHA
    466501c View commit details
    Browse the repository at this point in the history

  2. fix benchmark

    @jerch
    jerch committed May 20, 2023
    Configuration menu
    Copy the full SHA
    284cde8 View commit details
    Browse the repository at this point in the history

  3. remove spurious .only

    @jerch
    jerch committed May 20, 2023
    Configuration menu
    Copy the full SHA
    68abf10 View commit details
    Browse the repository at this point in the history

  4. revert wrong added file

    @jerch
    jerch committed May 20, 2023
    Configuration menu
    Copy the full SHA
    ebfa201 View commit details
    Browse the repository at this point in the history

  5. revert wrongly editied files

    @jerch
    jerch committed May 20, 2023
    Configuration menu
    Copy the full SHA
    3003185 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Merge pull request #2 from jerch/clusters-patch 

    working perf test and API test injection
    @PerBothner
    PerBothner authored May 21, 2023
    Configuration menu
    Copy the full SHA
    e87fa16 View commit details
    Browse the repository at this point in the history

  2. Update .eslintrc.json to include xterm-addon-unicode-graphemes/benchmark

    @PerBothner
    PerBothner committed May 21, 2023
    Configuration menu
    Copy the full SHA
    1a8c7da View commit details
    Browse the repository at this point in the history

  3. Optimize UnicodeGraphemeProvider for the ASCII case.

    @PerBothner
    PerBothner committed May 21, 2023
    Configuration menu
    Copy the full SHA
    fa89e17 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into clusters

    @jerch
    jerch authored May 21, 2023
    Configuration menu
    Copy the full SHA
    cf403bc View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Jun 27, 2023
    Configuration menu
    Copy the full SHA
    693f6b2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. Fix error in charProperties optimization. 

    Result should be 2, not 1.
Use a static field to avoid this kind of error
(though it might be slightly slower, depending on the compiler/toolchain).
    @PerBothner
    PerBothner committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    dc6818d View commit details
    Browse the repository at this point in the history

  2. Fix for lint the previous charProperties change.

    @PerBothner
    PerBothner committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    5568233 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Merge branch 'master' into clusters

    @Tyriar
    Tyriar authored Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7baff4e View commit details
    Browse the repository at this point in the history

  2. Add grapheme cluster test button to demo

    @Tyriar
    Tyriar committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    08a0914 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. Null out following columns after grapheme cluster

    @PerBothner
    PerBothner committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    6b24593 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Aug 4, 2023
    Configuration menu
    Copy the full SHA
    4204215 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2023

  1. Tweak to avoid line-ending spaces. 

    Line-ending spaces were unintentionally removed - this avoids the problem,
    @PerBothner
    PerBothner committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    dccfc11 View commit details
    Browse the repository at this point in the history

  2. Fix copyright year in new file.

    @PerBothner
    PerBothner committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    a0dc881 View commit details
    Browse the repository at this point in the history

  3. Tweak charProperties doc comment.

    @PerBothner
    PerBothner committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    88bfc6b View commit details
    Browse the repository at this point in the history

  4. Remove tailing space.

    @PerBothner
    PerBothner committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    988b3b1 View commit details
    Browse the repository at this point in the history

  5. Changed xterm-addon-unicode-graphemes version number to 0.1.0.

    @PerBothner
    PerBothner committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    7202979 View commit details
    Browse the repository at this point in the history

  6. Move precedingJoinState from EscapeSequenceParser to InputHandler 

    This allows InputHandler._parser to be IEscapeSequenceParser
rather than EscapeSequenceParser.
    @PerBothner
    PerBothner committed Aug 6, 2023
    Configuration menu
    Copy the full SHA
    f103540 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2023

  1. Split complicated conditional expression.

    @PerBothner
    PerBothner committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    b9abbc0 View commit details
    Browse the repository at this point in the history

  2. Expand doc comments for UnicodeCharProperties and UnicodeCharWidth.

    @PerBothner
    PerBothner committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    4fbc623 View commit details
    Browse the repository at this point in the history

  3. Rename local variable precedingInfo in InputHandler to precedingJoinS… 

    …tate
    @PerBothner
    PerBothner committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    302da18 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Move files imported from unicode-properties into subdirectory 

    Specifically  addons/xterm-addon-unicode-graphemes/src/third-party/.
    @PerBothner
    PerBothner committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    b9a4760 View commit details
    Browse the repository at this point in the history

  2. Add testOptions parameter to openTerminal in TestUtils. 

    This is used to control whether the UnicodeGraphemesAddon is loaded.
    @PerBothner
    PerBothner committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    3bfe5d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Merge branch 'master' into clusters

    @jerch
    jerch authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9b21786 View commit details
    Browse the repository at this point in the history

  2. Replace comments by assert message in unicode-graphemes tests 

    Also use plain equal instead of deepEqual (overkill).
    @PerBothner
    PerBothner committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    fb2c680 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    aac5d47 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    cf243ad View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    5994e25 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2023

  1. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    e3d3cdb View commit details
    Browse the repository at this point in the history

  2. Add more grapheme-cluster examples to test and demo

    @PerBothner
    PerBothner committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    f1bc956 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Aug 17, 2023
    Configuration menu
    Copy the full SHA
    2070cc4 View commit details
    Browse the repository at this point in the history

  4. Remove no-longer-applicable comment.

    @PerBothner
    PerBothner committed Aug 17, 2023
    Configuration menu
    Copy the full SHA
    6c1eb97 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2023

  1. Don't load unicode11 addon on demo startup.

    @PerBothner
    PerBothner committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    21fd545 View commit details
    Browse the repository at this point in the history

  2. Set unicode.activeVersion when loading UnicodeGraphemeProvider.

    @PerBothner
    PerBothner committed Aug 18, 2023
    Configuration menu
    Copy the full SHA
    00fd2b8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into clusters

    @Tyriar
    Tyriar authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e21e525 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    2204375 View commit details
    Browse the repository at this point in the history

  2. Provide with "15" and "15-graphemes" UnicodeProviders 

    Th former doesn't support grapheme clusters, except the old-fashioned
kind of simple modifiers.  However, "15-graphemes" (with full
cluster support) is the default.
    @PerBothner
    PerBothner committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    e5a2ebd View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. Merge remote-tracking branch 'upstream/master' into pr/PerBothner/4519-1

    @Tyriar
    Tyriar committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    5ccf4d3 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Remove precedingCodepoint - use precedingJoinState instead 

    repeatPrecedingCharacter (for REP sequence) changed to look at
the grapheme cluser to the "left" in the BufferLine, and repeat that.
This is an extension of the xterm behavior, and changes the
semantics of REP, so is not fully compatible.
However, the new behavior is cleaner and saner.

Moved precedingJoinState property to EscapeSequenceParser.
    @PerBothner
    PerBothner committed Aug 24, 2023
    Configuration menu
    Copy the full SHA
    dc6dd6d View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2023

  1. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Aug 27, 2023
    Configuration menu
    Copy the full SHA
    44e1977 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Fix 2 comment typos.

    @PerBothner
    PerBothner committed Sep 6, 2023
    Configuration menu
    Copy the full SHA
    630d213 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Merge branch 'master' into clusters

    @PerBothner
    PerBothner committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    930e5c4 View commit details
    Browse the repository at this point in the history

  2. Two testing-related fixes

    @PerBothner
    PerBothner committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    9963c58 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    427c472 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Merge branch 'master' into clusters

    @PerBothner
    PerBothner authored Sep 11, 2023
    Configuration menu
    Copy the full SHA
    bddff60 View commit details
    Browse the repository at this point in the history

  2. Increase node memory for lint in CI

    @Tyriar
    Tyriar committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    a003034 View commit details
    Browse the repository at this point in the history

  3. Add unicode-grapheme addon files to build artifacts

    @Tyriar
    Tyriar committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    1b5756c View commit details
    Browse the repository at this point in the history

  4. Add experimental note in readme

    @Tyriar
    Tyriar committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    17c4d09 View commit details
    Browse the repository at this point in the history

  5. Fix warnings in client.ts

    @Tyriar
    Tyriar committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    9e536ca View commit details
    Browse the repository at this point in the history

  6. Update to es2021

    @Tyriar
    Tyriar committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    24b932d View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Set repository to sub-directory 

    See xtermjs#4795
    @Tyriar
    Tyriar authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9ab0cd6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into clusters

    @Tyriar
    Tyriar authored Sep 12, 2023
    Configuration menu
    Copy the full SHA
    8183d1d View commit details
    Browse the repository at this point in the history

  3. Final polish

    @Tyriar
    Tyriar committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    32c6165 View commit details
    Browse the repository at this point in the history