-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add smoothScroll to scrollLines #4482
Conversation
@Tyriar hi. help review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tisilent, I made some changes to fix the tests and pass the scroll to top/bottom/line/pages calls through scrollLines
Oho @Tyriar , |
Test coverage is good enough currently, there are unit tests which run in node and use a Mock Viewport and then API tests that actually use the scroll apis in a browser context |
no.no. I learned how to write tests,Thanks @Tyriar |
I’am very sorry I had a wrong to sent the message. @Tyriar |
Fix #4121