Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect ligatures on browser side #2897

Closed
Tyriar opened this issue May 3, 2020 · 1 comment
Closed

Detect ligatures on browser side #2897

Tyriar opened this issue May 3, 2020 · 1 comment
Labels
area/addon/ligatures help wanted type/enhancement Features or improvements to existing features

Comments

@Tyriar
Copy link
Member

Tyriar commented May 3, 2020

Currently the ligatures addon needs a node.js environment to run which essentially means it can only run in Electron and will not run in VS Code like this as we're moving towards a more secure, node-free renderer. This idea is about trying to detect ligatures for a particular font by having a set of common ligatures (==, ===, <=, >=, ->, etc.) and using a canvas to draw them, toggling font-variant-ligatures on and off and comparing the output. If they're different, assume they're ligatures and draw them together using the character joiner API.

@LabhanshAgrawal
Copy link
Contributor

This may not be needed now?

@Tyriar Tyriar closed this as completed Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/ligatures help wanted type/enhancement Features or improvements to existing features
Projects
None yet
Development

No branches or pull requests

2 participants