Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search addon: Introduce a new selection type so that multiple ranges can be highlighted at once #1653

Closed
Tyriar opened this issue Sep 5, 2018 · 5 comments · Fixed by #3698
Labels
area/addon/search type/enhancement Features or improvements to existing features
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Sep 5, 2018

This would allow showing all matches of a search in the viewport and also not hijacking the regular selection.

Plan issue: #705

@Tyriar
Copy link
Member Author

Tyriar commented Jul 3, 2019

This is blocked on #1852

@roguexiaohuihui
Copy link

Are there any immediate plans to address this feature?

@Tyriar
Copy link
Member Author

Tyriar commented Jun 29, 2020

@roguexiaohuihui no, #1852 needs to be tackled first as well.

@dpdpbj
Copy link

dpdpbj commented Mar 8, 2022

Hi @Tyriar , any update for this issue? Seems the #1852 has been closed.

@Tyriar
Copy link
Member Author

Tyriar commented Mar 8, 2022

@dpdpbj it's on the plan for VS Code this month, we're looking at decorations in the scroll bar first though (microsoft/vscode#144595)

@Tyriar Tyriar added this to the 4.19.0 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/search type/enhancement Features or improvements to existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants