Characters are condensed

[mofux]

Since #1038 I am noticing that characters aren't as sharp as before. They also look not wide enough. Here is a direct comparision:

(expected) before #1038

(current) since #1038

I think only cached characters have this problem.

[Tyriar]

Something doesn't look right here, this is at 100% zoom level in the image above for before:

Something like this is I expect to see:

Did you zoom into the screenshots or something?

Also the only remaining issue AFAIK is that the character don't use standard spacing which is only tracked in microsoft/vscode#35695 atm

[mofux]

Hmmm.... can't reproduce this blurriness you're seeing when comparing both pictures:

But look at the space between the af in the staff. Before there was 1px space, now there is 2px space between the right line of the a and the left arm of the f. The same is also visible when checking the gap between the s and the t.

[Tyriar]

So I can tell "right.png" is an older version because the top-right of the f is cut off. What commit and font is that? I see a different font as the default on macOS.

[mofux]

"right" is on commit 22af08d. You can replicate the settings on Mac by pasting this into your dev console of the demo:

term.setOption('fontFamily', 'monaco');
term.setOption('fontSize', 13);

If you look on the t or f strokes, you can clearly see that they are 1px smaller on the wrong.png

[Tyriar]

This might be the same as #1050

[mofux]

It is, your patch from Tyriar@09c9cb4 solves this issue!