Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload not found #45

Closed
TheMaverickProgrammer opened this issue Feb 11, 2023 · 10 comments
Closed

File upload not found #45

TheMaverickProgrammer opened this issue Feb 11, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@TheMaverickProgrammer
Copy link

The issue #44 was preemptively closed without much testing. The newest version changes the drive slash only I think? And it still fails:

image

@owent
Copy link
Member

owent commented Feb 11, 2023

The slash problem is tested in https://github.com/xresloader/upload-to-github-release-test/actions/runs/4150466015.
I will check if there is any other problem.
Thanks.

@TheMaverickProgrammer
Copy link
Author

https://github.com/xresloader/upload-to-github-release-test/actions/runs/4150466015/workflow

The test image is on ubuntu. Try it on windows too.

@owent owent self-assigned this Feb 12, 2023
@owent owent added the bug Something isn't working label Feb 12, 2023
@owent
Copy link
Member

owent commented Feb 12, 2023

@TheMaverickProgrammer
This problem should be fixed now, we have test it in https://github.com/xresloader/upload-to-github-release-test/actions/runs/4155119464 and the release is here (https://github.com/xresloader/upload-to-github-release-test/releases/tag/main-79ccc08b).

Could you please test v1 branch if you have time? I will raise another PR later if v1 branch can solve your case.

@TheMaverickProgrammer
Copy link
Author

I'll try your branch today.

@TheMaverickProgrammer
Copy link
Author

TheMaverickProgrammer commented Feb 12, 2023

@owent How am I supposed to test? I've tried @v1, the commit hash directly (which github says doesn't support), and the release tag name:

image

image

@owent
Copy link
Member

owent commented Feb 13, 2023

@owent How am I supposed to test? I've tried @v1, the commit hash directly (which github says doesn't support), and the release tag name:

image

image

Please just use xresloader/upload-to-github-release@v1.

@TheMaverickProgrammer
Copy link
Author

Ok I'll try that.

@TheMaverickProgrammer
Copy link
Author

image
It works! Thank you so much!

@TheMaverickProgrammer
Copy link
Author

image
Proof

@owent
Copy link
Member

owent commented Feb 19, 2023

Thanks and it's published in v1.3.11 .

@owent owent closed this as completed Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants