Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XQEMU startup/runtime error handling #6

Open
mborgerson opened this issue Jun 14, 2018 · 1 comment
Open

Add XQEMU startup/runtime error handling #6

mborgerson opened this issue Jun 14, 2018 · 1 comment

Comments

@mborgerson
Copy link
Member

mborgerson commented Jun 14, 2018

If XQEMU fails to start, which might be caused by an invalid command line being passed to it (e.g. use controllers which are not connected), XQEMU-Manager will fail to connect to XQEMU over QMP. A cryptic "WinError 10061" error message will be displayed to users. In this case, we should be able to determine why XQEMU failed to start and report this to the user.

Additionally, XQEMU-Manager isn't aware of when the XQEMU subprocess crashes (e.g. hitting an assert), but it should be. We should be able to collect error messages and display them to the users. In the future, automated error reporting would be nice too but that's a separate issue.

@gandalfthewhite19890404

Xqemu-manager does not handle xqemu stopping either - tested on xqemu 5d4058d6 with xqemu-manager 8e7cfe7.

@mborgerson mborgerson changed the title Gracefully handle XQEMU crashes Add XQEMU startup/runtime error handling Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants