Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings dialog does not have a "Save changes" button #15

Open
JayFoxRox opened this issue Jun 29, 2018 · 0 comments
Open

Settings dialog does not have a "Save changes" button #15

JayFoxRox opened this issue Jun 29, 2018 · 0 comments
Labels
good first issue Good for newcomers

Comments

@JayFoxRox
Copy link
Member

In my opinion the current settings dialog is unintuitive design.
I always have the instinct to go back to confirm that my settings have been changed, because just closing a dialog doesn't confirm to me that anything has been saved.

It's also odd that you have to press the ❌ at the top of the window after working yourself from top-to-bottom for configuring each setting in the window.

The solution to this does not necessarily have to be a button labeled "Save changes" - other solutions are also possible, as long as it's intuitive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant