Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache responses #40

Open
jhamman opened this issue Jul 30, 2024 · 2 comments · May be fixed by #42
Open

Cache responses #40

jhamman opened this issue Jul 30, 2024 · 2 comments · May be fixed by #42

Comments

@jhamman
Copy link
Contributor

jhamman commented Jul 30, 2024

This project doesn't seem to take advantage of Xpublish's cache tooling. This seems like a low-lift and something that is likely to pay pretty substantial performance dividends.

@jhamman jhamman linked a pull request Jul 30, 2024 that will close this issue
@mpiannucci
Copy link
Contributor

One thing to explore here is utilizing a CDN with Cache-Control headers if cacheing on a specific request is desired. That way the server does no work if an exact request is repeated. The hard part would be somehow incorporating if the dataset had changed or updated into that strategy though.

@jhamman
Copy link
Contributor Author

jhamman commented Aug 7, 2024

@mpiannucci -- this is a good suggestion and one that we should probably consider for other xpublish routers as well. In #45, I've tried out fastapi-cache which should provide the Cache-Control functionality out of the box (more work/testing is needed there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants