Skip to content
This repository has been archived by the owner on May 30, 2024. It is now read-only.

Support AlternateId for Assets #40

Closed
christianduic opened this issue Mar 7, 2024 · 4 comments
Closed

Support AlternateId for Assets #40

christianduic opened this issue Mar 7, 2024 · 4 comments

Comments

@christianduic
Copy link

I'm currently testing MediaKind as a replacement for AMS.

For backwards compatibility reasons it would be much appreciated to have support in the Assets.CreateOrUpdateAsync to provide an AltenateId so it can be set in the AssetProperties.

Do you think this is a reasonable improvement to the library?

@xpouyat
Copy link
Owner

xpouyat commented Mar 7, 2024

Oh you are right. I can add this parameter to the CreateOrUpdateAsync method.
I can also add a method which takes the asset properties as parameter for the creation.

Something like we have for content key policy creation
ContentKeyPolicySchema CreateAsync(string contentKeyPolicyName, ContentKeyPolicyProperties properties);

@xpouyat xpouyat mentioned this issue Mar 7, 2024
Merged
@xpouyat
Copy link
Owner

xpouyat commented Mar 7, 2024

Possible in v1.2.1 https://www.nuget.org/packages/MK.IO/1.2.1

@christianduic
Copy link
Author

Thank you! That solves our issue.

A new CreateAsync taking the properties could be more compact, but this change is good enought in our case 💪🏻

@xpouyat
Copy link
Owner

xpouyat commented Mar 8, 2024

Great. FYI, I also tested .AssetId but it seems ignored at Creation. I will report it to MediaKind.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants